[PATCH] D82433: [ELF] -r: don't parse @ (symbol versioning) for .symver inline asm in bitcode

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

Looks reasonable. You don't need `SHNDX` I think.



================
Comment at: lld/test/ELF/lto/version-script2.ll:3
 
-;; Test we parse symbol versions before LTO, otherwise we may get a symbol
-;; named "foo@@VER1", but not "foo" with the version VER1.
+;; For non-relocatable output, Test we parse symbol versions after LTO,
+;; otherwise we may get a symbol named "foo@@VER1", but not "foo" with the
----------------
Test -> test


================
Comment at: lld/test/ELF/lto/version-script2.ll:14
+; CHECK:      UND         bar{{$}}
+; CHECK-NEXT: [[#SHNDX:]] foo@@VER1
+
----------------
This defines `SHNDX` which is never used I think. Why just you didn't use a section index instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82433/new/

https://reviews.llvm.org/D82433