[PATCH] D82366: [yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I have no particular opinion on using some specific sizing value or not as the case may be, so I'm happy with whichever approach is agreed upon.



================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:256-257
+
+  // Is used when a content is read as an array of bytes.
+  Optional<std::vector<uint8_t>> ContentBuf;
 };
----------------
It probably makes sense to place this and `Content` next to each other, since they are logically related.


================
Comment at: llvm/test/tools/yaml2obj/ELF/content-array.yaml:5
+## Check we are able to use ContentArray to create multi-line descriptions
+## of sections contents with comments on the same line.
+# RUN: yaml2obj --docnum=1 %s -o %t1
----------------
sections -> section


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82366/new/

https://reviews.llvm.org/D82366