[PATCH] D82145: [NFC][PowerPC] Legalize SREM/UREM directly on P9.

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 00:29:58 PDT 2020


lkail added a comment.

> I am not sure whether this is preferable. If so, the predictions will change after making OperationAction `Legal`...

Maybe I'm not making myself clear. We can make adding `opt` RUN lines in `llvm/test/CodeGen/PowerPC/ppc64-P9-mod.ll` an NFC patch

  ; RUN: llc < %s -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr9 -verify-machineinstrs | FileCheck %s
  ; RUN: llc < %s -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr9 -verify-machineinstrs | FileCheck %s
  ; RUN: llc < %s -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 | FileCheck %s -check-prefix=CHECK-PWR8 -implicit-check-not mod[us][wd]
  ; RUN: opt < %s -div-rem-pairs -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr9 | \
  ; RUN:   llc -verify-machineinstrs | FileCheck -check-prefix=CHECK-DIV-REM-PAIRS %s
  ; RUN: opt < %s -div-rem-pairs -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr9 | \
  ; RUN:   llc -verify-machineinstrs | FileCheck -check-prefix=CHECK-DIV-REM-PAIRS %s
  ; RUN: opt < %s -div-rem-pairs -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 | \
  ; RUN:   llc -verify-machineinstrs | FileCheck %s -check-prefix=CHECK-PWR8-DIV-REM-PAIRS -implicit-check-not mod[us][wd]

The second patch, we make actions `Legal` and compare the result of the NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82145/new/

https://reviews.llvm.org/D82145





More information about the llvm-commits mailing list