[PATCH] D82145: [NFC][PowerPC] Legalize SREM/UREM directly on P9.

Tue Jun 23 19:59:37 PDT 2020

Esme added a comment.

In D82145#2110509 <https://reviews.llvm.org/D82145#2110509>, @lkail wrote:

> It looks not an NFC patch to me, the test predicates are changed
>
>   CHECK: modsw -> CHECK-NOT: modsw
>
>
> I'm curious if it is unchanged that `opt` is added to RUN lines while the OperationAction keeps `Custom`. If so, adding `opt` to RUN lines can be an NFC patch, and making OperationAction `Legal` can be another FC patch.

Adding `opt` changed the predictions because the pass `div-rem-pairs` fixed the case `@blocks_modulo_div_sw`. If the pass is already added, making OperationAction `Legal` will not cause any change.  I will separate the patch to 2 patches to make this clear.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82145/new/

https://reviews.llvm.org/D82145