[PATCH] D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 19:27:09 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:231
+      // Check if off2 falls within that margin; if so off1+off2 can't overflow.
+      unsigned Alignment = GA->getGlobal()->getAlignment();
+      if (Offset2 != 0 && Offset2 >= Alignment)
----------------
FYI, D80368 removes GlobalValue::getAlignment().  Value::getPointerAlignment() is the suggested replacement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79690/new/

https://reviews.llvm.org/D79690





More information about the llvm-commits mailing list