[PATCH] D82420: [SimplifyCFG] Drop debug loc in SpeculativelyExecuteBB

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

The issue triggers quite often in a stage2 build: I count 50K instances and the build is less than half complete.

Here's a synthetic example. Before the patch, lldb single-steps to line 7 after visiting line 4:

  frame #0: 0x0000000100000f6a t`main(argc=1, argv=0x00007ffeefbff8e8) at t.cc:7:3 [opt]
     4      int y = x;
     5      if (y) {
     6        y += 9;
  -> 7      }
     8      y -= 11;
     9      printf("%d\n", y);
     10     return 0;



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2149
+    if (!SpeculatedStoreValue || &I != SpeculatedStore)
+      I.setDebugLoc({});
     I.dropUnknownNonDebugMetadata();
----------------
davide wrote:
> I prefer `DebugLoc()` but up to you.
I'll fix this before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82420/new/

https://reviews.llvm.org/D82420