[PATCH] D82344: [NewPM] Make PMs and adaptor passes for PMs unskippable

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 17:49:11 PDT 2020


ychen updated this revision to Diff 272878.
ychen added a comment.

- Simplify by letting pass optionally implement `static bool isSkippable()`. This also make the skipping logic internal to PassInstrumentation, no change is needed in PassManger itself for the sake of performing skipping.
- All the implementation are through the type-erased API. The type traits in PassInstrumentation is for handling cases where adaptor passes instantiated for regular passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82344/new/

https://reviews.llvm.org/D82344

Files:
  llvm/include/llvm/Analysis/CGSCCPassManager.h
  llvm/include/llvm/IR/PassInstrumentation.h
  llvm/include/llvm/IR/PassManager.h
  llvm/include/llvm/IR/PassManagerInternal.h
  llvm/include/llvm/Transforms/Scalar/LoopPassManager.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82344.272878.patch
Type: text/x-patch
Size: 5581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/8d4ce4cf/attachment.bin>


More information about the llvm-commits mailing list