[PATCH] D82280: Fix for NVPTX module asm regression

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Thank you for providing the examples.

In D82280#2110206 <https://reviews.llvm.org/D82280#2110206>, @jdtatz wrote:

>




> with llvm-10 invalid ptx is generated
> 
>                                           // Start of file scope inline assembly
>   .global .b32 val;
>   
>                                           // End of file scope inline assembly
>   //
>   // Generated by LLVM NVPTX Back-End
>   //
>   
>   .version 3.2
>   .target sm_20
>   .address_size 32
>   
>                                           // Start of file scope inline assembly
>   .global .b32 val;

Ouch. We've generated it twice, with one of the instances being in the wrong place. That's indeed not good.

> with this patch valid ptx is generated
> 
>   //
>   // Generated by LLVM NVPTX Back-End
>   //
>   
>   .version 3.2
>   .target sm_20
>   .address_size 32
>   
>                                           // Start of file scope inline assembly
>   .global .b32 val;

I like this much better. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82280/new/

https://reviews.llvm.org/D82280