[PATCH] D81620: [SVE] Allow scalable vector splats to be gep indices

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 15:39:09 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/IR/Constants.cpp:1572
 
 const APInt &Constant::getUniqueInteger() const {
   if (const ConstantInt *CI = dyn_cast<ConstantInt>(this))
----------------
efriedma wrote:
> Constant::getUniqueInteger() is a terrible API.  I'd prefer to fix the callers so it doesn't need to handle scalable vectors.
That may be true, but my version is better than what existed previously.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81620/new/

https://reviews.llvm.org/D81620





More information about the llvm-commits mailing list