[PATCH] D57023: [MsgPack] New MsgPackDocument class
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 23 15:39:08 PDT 2020
dblaikie added inline comments.
================
Comment at: llvm/trunk/include/llvm/BinaryFormat/MsgPackDocument.h:123-132
+ /// Get an ArrayDocNode for an array node. If Convert, convert the node to an
+ /// array node if necessary.
+ ArrayDocNode &getArray(bool Convert = false) {
+ if (getKind() != Type::Array) {
+ assert(Convert);
+ convertToArray();
+ }
----------------
Excuse the delayed review - found this while investigating other issues. I believe this code is invalid & is an aliasing violation (taking a pointer to ArrayDocNode (similarly with MapDocNode) when it's not pointing to an object of that type).
Can you please fix this code to not do that?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57023/new/
https://reviews.llvm.org/D57023
More information about the llvm-commits
mailing list