[PATCH] D81184: [lld][ELF][AArch64] Handle R_AARCH64_PLT32 relocation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 15:05:17 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lld/test/ELF/aarch64-range-thunk-extension-plt32.s:3
+// RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t.o
+// RUN: echo "SECTIONS { \
+// RUN:         .text.1 0x10000 : { *(.text.1) } \
----------------
Nit: use `'`

`"` can appear in linker scripts and using `'` can avoid extra escape in some cases.


================
Comment at: lld/test/ELF/aarch64-range-thunk-extension-plt32.s:24
+// CHECK-LABEL: <callee>:
+// CHECK-NEXT: 200000000:      ret
+
----------------
Indent this line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81184/new/

https://reviews.llvm.org/D81184





More information about the llvm-commits mailing list