[PATCH] D82410: [llvm-install-name-tool] Add -id option

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test:11
+
+## Specifying -id more than once:
+# RUN: llvm-install-name-tool -id /usr/lib/B_long -id /usr/lib/K_long -id /usr/A_short  %t
----------------
NOTE: this behavior is different from cctool's. The cctool's version throws an error on specifying multiple `-id` options, but keeping @jhenderson comments in mind from `-delete_rpath`, we allowed for multiple `-id` options currently.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test:17
+
+## Specifying -id with empty string:
+# RUN: not llvm-install-name-tool -id '' %t 2>&1 | \
----------------
NOTE: this behavior is also different from cctool's. cctools allows for an empty id string (i.e `-id ''`). But we thought it would not be useful to allow for empty strings and so we throw an error right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82410/new/

https://reviews.llvm.org/D82410