[PATCH] D82270: Added a Printer to the FunctionPropertiesAnalysis

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D82270#2109923 <https://reviews.llvm.org/D82270#2109923>, @jdoerfert wrote:

> In D82270#2106860 <https://reviews.llvm.org/D82270#2106860>, @mtrofin wrote:
>
> > What's the value of having the result type have the analyze method? Is there a scenario where we want to get the result and then re-analyze it?
>
>
> In the new-PM if you preserve the analysis it doesn't need to be recomputed, I thought. Or maybe I misunderstand your question. Could you elaborate?
>
> [EDIT: Do you mean the `...Info` struct? It is used by two passes, right?]


What I mean was, why not let the computation happen in the Analysis::run, and the Info is basically an object not meant to be mutated. This is because the PM will call ::run to recompute, and we don't really have (or want to have) a scenario where we want someone to call Info::analyze() (unless I'm missing something)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82270/new/

https://reviews.llvm.org/D82270