[PATCH] D82331: TableGen/GlobalISel: Partially fix nontrivial, custom predicates

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

I can't think of any better way to do this off the top of my head.

Maybe @dsanders has some opinions here?



================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:1048
+
+  using PredicateFilterFunc = std::function<bool(const PredicateTy&)>;
+
----------------
I think it's worth documenting what the filter functions are for in a comment here.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:1050-1052
+  template <class... Args>
+  void emitFilteredPredicateListOpcodes(PredicateFilterFunc ShouldEmitPredicate,
+                                        MatchTable &Table, Args &&... args) {
----------------
Probably worth documenting in a comment too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82331/new/

https://reviews.llvm.org/D82331