[PATCH] D82390: [PowerPC] Fix the implicit operands in PPCInstrInfo::PredicateInstruction()

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 13:59:20 PDT 2020


efriedma added a comment.

I don't think it makes sense to try to fix implicit operands generically. If we're changing the opcode in a way that affects the operands, the code making that change should be aware of what the change needs to be.  That code can add or remove operands as necessary.

"Automatically" fixing the operands later might produce the same result, but it's harder to understand what's happening.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82390/new/

https://reviews.llvm.org/D82390





More information about the llvm-commits mailing list