[PATCH] D81662: [NFC] Use ADT/Bitfields in Instructions

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 13:26:49 PDT 2020


aprantl added a comment.

Can you add a comment that explains when and why to use this over actual C(++) bitfields?



================
Comment at: llvm/include/llvm/ADT/Bitfields.h:25
+
+/// Helpers to pack / unpack typed bitfields into an unsigned integer.
+/// e.g.
----------------
Does this doxygen comment just hang in open space? It would be unfortunate if it didn't make it into the documentation just because it's not attached to a syntax node.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81662/new/

https://reviews.llvm.org/D81662





More information about the llvm-commits mailing list