[PATCH] D81695: [flang] Turn off FLANG_ENABLE_WERROR by default

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 12:54:10 PDT 2020


mehdi_amini added a comment.

In D81695#2093046 <https://reviews.llvm.org/D81695#2093046>, @sscalpone wrote:

> @isuruf Are there some warning that cannot be removed with reasonable effort?


Since I'm just building with gcc-9 for some reason right now, here is a tough warning:

  llvm-project/llvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h:1534:27: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
   1534 |       return std::move(Err);

Clang could warn if we remove the std::move...

In D81695#2109038 <https://reviews.llvm.org/D81695#2109038>, @tskeith wrote:

> In D81695#2108974 <https://reviews.llvm.org/D81695#2108974>, @DavidTruby wrote:
>
> > There is another example here of our BuildBots failing for very spurious warnings due to -Werror:
> >  http://lab.llvm.org:8014/builders/flang-aarch64-ubuntu-clang/builds/229/steps/build-unified-tree/logs/stdio
>
>
> The warning is not spurious, so this example shows `-Werror` in the best possible light:


Absolutely: this is why we should have bots with Werror enabled (but not with gcc-9 for example)
(This is separate to the default setting though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81695/new/

https://reviews.llvm.org/D81695





More information about the llvm-commits mailing list