[PATCH] D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter.

Nick Lewycky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 11:15:54 PDT 2020


nicholas added inline comments.


================
Comment at: llvm/include/llvm-c/Core.h:631
+ */
+LLVMTypeRef LLVMGetTypeByName2(LLVMContextRef C, const char *Name);
+
----------------
clang-tidy readability-identifier-naming doesn't like 'LLVMGetTypeByName2'. Should I ignore this because it's standard style for the LLVM C API? Or what should I change it to?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78793/new/

https://reviews.llvm.org/D78793





More information about the llvm-commits mailing list