[PATCH] D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 11:15:53 PDT 2020


aemerson added a comment.

In D82329#2108346 <https://reviews.llvm.org/D82329#2108346>, @david-arm wrote:

> Perhaps this change is good enough? We call computeValueLLTs just before lowerFormalArguments, which will detect the scalable type and fall back anyway even if the LLT type is wrong. The other option is to add yet another fallBackOnDAGISel type callback that allows the backend to reject certain types before we create the vregs.


I think we just need to move the check from lowerFormalArguments to the for-loop before the call to it, and emit a remark to explain why we're falling back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82329/new/

https://reviews.llvm.org/D82329





More information about the llvm-commits mailing list