[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2
+set(LLVM_TARGET_DEFINITIONS OMP.td)
+tablegen(LLVM OMP.h.inc --gen-directive-decls)
+add_public_tablegen_target(omp_gen)
----------------
jdoerfert wrote:
> clementval wrote:
> > thakis wrote:
> > > All other tblgen outputs are called .inc, not .h.inc. Any reason this one's different?
> > There is a `.cpp.inc` coming in a following patch. 
> @clementval ^ 
...why would you want to include a cpp file?

If it's for definitions of generated functions, I think the usual pattern is to put that in the .inc too behind a define and define that in one cpp file that includes the .inc. (Examples: GET_DAGISEL_BODY, GET_INSTRINFO_MC_DESC, PRINT_ALIAS_INSTR etc -- `rg -B5 '#include.*\.inc' clang llvm` shows many examples).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736