[PATCH] D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham marked an inline comment as done.
simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:729
+    if (!Subtarget->hasFullFP16()) {
+      setAllExpand(MVT::bf16);
+      setOperationAction(ISD::BITCAST, MVT::bf16, Custom);
----------------
dmgreen wrote:
> I'm not sure if setAllExpand should be guarded by !hasFullFP16? In either case they would be in pretty much the same situation - most operations are illegal with bf16. Does something go wrong always doing this?
(Huh, where did my reply to this comment go? I must have forgotten to press 'Save Draft'.)

I did it that way in order to avoid affecting the hasFullFP16 code path, because that way I was confident I wouldn't break it as a side effect :-) But I've just tried out the version with `setAllExpand` unconditional, and it seems to work just as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82372/new/

https://reviews.llvm.org/D82372