[PATCH] D81907: [llvm-objcopy] Fix help text

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:403
 static void printHelp(const opt::OptTable &OptTable, raw_ostream &OS,
-                      StringRef ToolName) {
-  OptTable.PrintHelp(OS, (ToolName + " input [output]").str().c_str(),
+                      StringRef ToolName, ToolType ToolEnum) {
+  StringRef HelpText;
----------------
alexshap wrote:
> jhenderson wrote:
> > alexshap wrote:
> > > nit: ToolType ToolEnum -> ToolType Tool
> > > 
> > > ToolName can be derived from ToolType, we probably don't need to pass it as an argument.
> > > 
> > > 
> > How would you and others feel about passing in the real executable name and printing that instead? It was an idea I had, but didn't suggest it before.
> I would be fine with that
@jhenderson What do you mean by "real executable name"? So what should I be doing here now? We keep the ToolName? Sorry for not understanding what you guys meant exactly 😔 

Currently I have made the change ToolType ToolEnum -> ToolType Tool. Not sure about ToolName yet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81907/new/

https://reviews.llvm.org/D81907