[PATCH] D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 09:04:19 PDT 2020


simon_tatham marked an inline comment as done.
simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrVFP.td:166
 
-def : FPRegs16Pat<(f16 (alignedload16 addrmode5fp16:$addr)),
-                  (VLDRH addrmode5fp16:$addr)>;
-def : FPRegs16Pat<(bf16 (alignedload16 addrmode5fp16:$addr)),
-                  (VLDRH addrmode5fp16:$addr)>;
+foreach fptype = [f16, bf16] in {
+  def : Pat<(fptype (alignedload16 addrmode5fp16:$addr)),
----------------
dmgreen wrote:
> I would expect HasNoFPRegs16 + f16 to never come up? If so you could alternatively move that single pattern back into the instruction above.
I'll give that a try too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82372/new/

https://reviews.llvm.org/D82372





More information about the llvm-commits mailing list