[PATCH] D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 09:04:19 PDT 2020


amyk added inline comments.


================
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:309
 
+// P10 Vector insert with immediate built-ins
+BUILTIN(__builtin_altivec_vinsw, "V4UiULLiIi", "")
----------------
End with a period.


================
Comment at: clang/lib/Headers/altivec.h:16834
+
+/* vec_replace */
+#ifdef __LITTLE_ENDIAN__
----------------
Nit: Space after the comment of the name. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82359/new/

https://reviews.llvm.org/D82359





More information about the llvm-commits mailing list