[PATCH] D82248: AMDGPU: Don't ignore carry out user when expanding add_co_pseudo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 07:59:16 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:640
   if (RC == &AMDGPU::SReg_64RegClass) {
+    if (SrcReg == AMDGPU::SCC) {
+      BuildMI(MBB, MI, DL, get(AMDGPU::S_CSELECT_B64), DestReg)
----------------
alex-t wrote:
> https://reviews.llvm.org/D82194 contains same change.
> I'd like it to land first. It also may affect the test.
This could be split out into an independent patch. This also was from the already committed patch which was reverted.

(I'm also not sure if situations like this should be inserting an and with exec; probably not from this context though)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82248/new/

https://reviews.llvm.org/D82248





More information about the llvm-commits mailing list