[PATCH] D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 07:58:42 PDT 2020


NeHuang added a comment.

Overall looks good to me.  
Would be better to add tests for assembly reader check in `llvm/test/MC/PowerPC`



================
Comment at: llvm/lib/Target/PowerPC/PPC.h:114
+    /// Fix up is VK_PPC_GOT_TPREL_PCREL
+    MO_TPREL_FLAG = 32,
+
----------------
stefanp wrote:
> Why 32 and not 16?
16 is used for `MO_TLSGD_FLAG = 16` in https://reviews.llvm.org/D82315 
We originally planned to set 32 here for the convenience of code merging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81947/new/

https://reviews.llvm.org/D81947





More information about the llvm-commits mailing list