[PATCH] D82339: [HIP][AMDGPU] Do not perform Promote Alloca optimization for GPU kernels with dynamic LDS usage.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

Needs testcase



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:740
+        // Do not promote alloca to static LDS if this function uses any dynamic shared memory
+        // since mixed static/dynamic LDS is not fully supported yet.
+        uint64_t AllocSize = DL.getTypeAllocSize(GV.getValueType());
----------------
I think this needs more clarification, since this does handle dynamic LDS as OpenCL uses it through a kernel argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82339/new/

https://reviews.llvm.org/D82339