[PATCH] D82370: [AMDGPU] Rework SCC copy

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 05:17:27 PDT 2020


piotr created this revision.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl, arsenm.
Herald added a project: LLVM.
piotr added a reviewer: arsenm.

In D81925 <https://reviews.llvm.org/D81925>, S_CMP_LG_U64 was used for copies to SCC,
which is only safe for hw with hasScalarCompareEq64.
Rework this part to use the lower part for the comparison
and use S_CMP_LG_U32 instead.

Additionally, remove pattern for selects with 64-bit
inputs, which are rare, because handling them properly
requires more thought.

Depends on D81925 <https://reviews.llvm.org/D81925>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82370

Files:
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SOPInstructions.td
  llvm/test/CodeGen/AMDGPU/addrspacecast.ll
  llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll
  llvm/test/CodeGen/AMDGPU/sdiv64.ll
  llvm/test/CodeGen/AMDGPU/srem64.ll
  llvm/test/CodeGen/AMDGPU/trunc.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82370.272682.patch
Type: text/x-patch
Size: 24275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200623/f4ebdfbf/attachment-0001.bin>


More information about the llvm-commits mailing list