[PATCH] D81649: [AMDGPU/MemOpsCluster] Compute `width` for `MIMG` instruction class.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 03:08:24 PDT 2020


hsmhsm marked an inline comment as done.
hsmhsm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/cluster_stores.ll:8-10
+
+; DBG: Num BaseOps: {{[1-9]+}}, Offset: {{[0-9]+}}, OffsetIsScalable: {{[01]}}, Width: {{[1-9]+}}
+
----------------
hsmhsm wrote:
> foad wrote:
> > I don't think this really adds any value to the test, unless you're going to check for specific numbers like "Width: 4" or similar?
> I can do that by extracting width by dbg dump, and updating the same in the test.
Morever, to clarify, my intension here was to test that `Width` is greather than 0 (should not be 0)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81649/new/

https://reviews.llvm.org/D81649





More information about the llvm-commits mailing list