[PATCH] D82017: [DebugInfo/DWARF] - Do not hang when CFI are truncated.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp:255
+    EXPECT_THAT_ERROR(
+        ParseCFI(TestCIE, {Inst, /*Op1=*/0}),
+        FailedWithMessage("unable to decode LEB128 at offset 0x00000002: "
----------------
jhenderson wrote:
> Here and below, should `Op1` be `RegNum` (that's what it was before)?
I think no, because now `CheckOp_ULEB128_Expr` is a generic lamda, that knows that
an instruction checked has 3 operands of known types, but probably it shouldn't do any assumptions
about their meanings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82017/new/

https://reviews.llvm.org/D82017