[PATCH] D82296: [ObjectYAML][ELF] Add support for emitting the .debug_pubnames section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D82296#2108025 <https://reviews.llvm.org/D82296#2108025>, @Higuoxing wrote:

> In D82296#2106599 <https://reviews.llvm.org/D82296#2106599>, @jhenderson wrote:
>
> > This patch LGTM. Don't spend hours of time working on supporting .pubnames/.pubtypes however, as they aren't widely used by my understanding. Still, for completeness, it doesn't hurt to support them for now.
>
>
> Yeah, I will not spend too much time on them. In the next patch, I will replace the `InitialLength` with `Format` and `Length` just as what we do in other sections. As for supporting multiple sets of entries, if nobody requests it, I will not work on it.


I think if you end up with some spare time towards the end of the project, it doesn't hurt to "finish this off". Just not at the cost of more useful features. I do agree with the Length change though. Consistency is quite important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82296/new/

https://reviews.llvm.org/D82296