[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

[Ronak Chauhan via Phabricator via llvm-commits]

rochauha updated this revision to Diff 272663.
rochauha added a comment.

Made changes based on reviews by @madhur13490 and @jhenderson.

- Reverse the order of function definitions.
- std::string => StringRef.
- std::stringstream => raw_string_ostream.
- Full stops for comments.
- Set AddressSize = 8.
- Remove error handling when reading bytes with DataExtractor since we already check for Bytes.size() == 64 beforehand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713

Files:
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80713.272663.patch
Type: text/x-patch
Size: 21901 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200623/4ff2c899/attachment-0001.bin>