[PATCH] D57779: [SLP] Add support for throttling.

[Dinar Temirbulatov via Phabricator via llvm-commits]

dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2276
+  struct TreeState {
+    using TreeStateTy = SmallVector<std::unique_ptr<TreeState>, 2>;
+
----------------
dtemirbulatov wrote:
> ABataev wrote:
> > Why `unique_ptr` again? Why not a `TreeState` directly? Just `SmallVector<TreeState, 2>;`
> ok
hmm. Tree state is too complex, we don't have to make it movable or copyable. Why unique_ptr is not good here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779