[PATCH] D82307: [Alignment][NFC] Use Align for TargetCallingConv::OrigAlign

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 23:25:44 PDT 2020


courbet added a comment.

I see several places that never call `setOrigAlign()`, e.g. in GlobalISel CallLowering:

  ISD::ArgFlagsTy Flags = OrigFlags;
              if (Part == 0) {
                Flags.setSplit();
              } else {
                Flags.setOrigAlign(Align(1));
                if (Part == NumParts - 1)
                  Flags.setSplitEnd();
              }
              Args[i].Regs.push_back(Reg);
              Args[i].Flags.push_back(Flags);

How did you infer that this change was safe ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82307/new/

https://reviews.llvm.org/D82307





More information about the llvm-commits mailing list