[PATCH] D82276: Make ninja smart console builds more pretty

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 23:04:45 PDT 2020


phosek added a comment.

In D82276#2106260 <https://reviews.llvm.org/D82276#2106260>, @davezarzycki wrote:

> Unless I'm missing something, consolidating this logic into LLVM's CMakeLists.txt will break stand alone builds of sub-projects and external projects that depend on this logic.
>
> Was there a policy change? Are stand alone builds no longer supported? Are external projects no longer allowed to use LLVM's GenerateVersionFromVCS.cmake?


There wasn't, but we only need to call `get_source_info` from clang, lld or lldb when they're being built as standalone. When being built as part of LLVM, we can just reuse the LLVM revision and repository.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82276/new/

https://reviews.llvm.org/D82276





More information about the llvm-commits mailing list