[PATCH] D82337: [Triple] support macOS 11 os version number

Mon Jun 22 23:04:44 PDT 2020

arphaman marked an inline comment as done.
arphaman added inline comments.

================
Comment at: llvm/unittests/ADT/TripleTest.cpp:1264
+
+  T = Triple("x86_64-apple-darwin20.1");
+  EXPECT_TRUE(T.isMacOSX());
----------------
mstorsjo wrote:
> arphaman wrote:
> > I will remove this triple as this use-case is not relevant and the check below is failing.
> When reading the changes to `getMacOSXVersion` above I was curious about this case as well - as the code there implies the following one would be 12.0, not 11.1 - but I presume it's too soon to say what that will be? So in that case, removing the test case for now sounds sensible.
Correct.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82337/new/

https://reviews.llvm.org/D82337