[PATCH] D81943: [SROA] Teach SROA to perform no-op pointer conversion.

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:1709
+      // Convert pointers if they are pointers from the same address space or
+      // different non-integral address spaces with the same pointer size.
+      return OldAS == NewAS ||
----------------
I think "different non-integral" is backwards from the code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81943/new/

https://reviews.llvm.org/D81943