[PATCH] D80285: [mlir] make the bitwidth of device side index computations configurable

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 21:29:34 PDT 2020


mehdi_amini added a comment.

nn



================
Comment at: mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h:385
+                           /*indexBitwidth=*/kDeriveIndexBitwidthFromDataLayout,
+                           /*useAlignedAlloc=*/false},
                        PatternBenefit benefit = 1);
----------------
I am puzzled how is this working?

This default value for this parameter is mapped to a reference member, how isn't it gonna lead to "use-after-free"?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80285/new/

https://reviews.llvm.org/D80285





More information about the llvm-commits mailing list