[PATCH] D82193: [OpenMPOpt] ICV macro definitions

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Once the test is adjusted for both PMs, LGTM.



================
Comment at: llvm/test/Transforms/OpenMP/icv_remarks.ll:1
+; opt -passes=openmpopt -pass-remarks=openmp-opt -openmp-print-icv-values -disable-output < %s 2>&1 | FileCheck %s
+; RUN: opt -openmpopt -pass-remarks=openmp-opt -openmp-print-icv-values -disable-output < %s 2>&1 | FileCheck %s
----------------
sstefan1 wrote:
> In the new PM remarks are emitted in reverse order. I wasn't sure how to handle this nicely.
Either:
1) Make all check lines `CHECK-DAG:`, or
2) Use two different prefixes.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82193/new/

https://reviews.llvm.org/D82193