[PATCH] D82320: [NPM] Attempt to run opt passes specified via -foo-pass under NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D82320#2107762 <https://reviews.llvm.org/D82320#2107762>, @ychen wrote:

> This is great! What are these failures look like? Do they look straightforward to fix?


Updated the description.
Most of them are passes either not ported to NPM or don't have the same name in PassRegistry.def as their old name.
I was thinking about potentially creating some wrapper class around old PM passes but I don't think that would work.



================
Comment at: llvm/tools/opt/opt.cpp:75
+static cl::opt<bool>
+    EnableNewPassManager("enable-new-pass-manager",
+                         cl::desc("Enable the new pass manager"));
----------------
ychen wrote:
> This is a bit verbose to me. Maybe `enable-new-pm`. It is fine either way.
Done, matches another option in NewPMDriver.cpp


================
Comment at: llvm/tools/opt/opt.cpp:742
+  if (EnableNewPassManager || PassPipeline.getNumOccurrences() > 0) {
+    if (!EnableNewPassManager && PassList.size()) {
       errs()
----------------
ychen wrote:
> `PassPipeline.getNumOccurrences() > 0` is more intuitive?
That's definitely better, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82320/new/

https://reviews.llvm.org/D82320