[PATCH] D82320: [NPM] Attempt to run opt passes specified via -foo-pass under NPM

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

This is great! What are these failures look like? Do they look straightforward to fix?



================
Comment at: llvm/tools/opt/opt.cpp:75
+static cl::opt<bool>
+    EnableNewPassManager("enable-new-pass-manager",
+                         cl::desc("Enable the new pass manager"));
----------------
This is a bit verbose to me. Maybe `enable-new-pm`. It is fine either way.


================
Comment at: llvm/tools/opt/opt.cpp:742
+  if (EnableNewPassManager || PassPipeline.getNumOccurrences() > 0) {
+    if (!EnableNewPassManager && PassList.size()) {
       errs()
----------------
`PassPipeline.getNumOccurrences() > 0` is more intuitive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82320/new/

https://reviews.llvm.org/D82320