[PATCH] D82232: Add hasNItemsOrLess and container variants of hasNItems and friends

[Rahul Joshi via Phabricator via llvm-commits]

jurahul marked 2 inline comments as done.
jurahul added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1963
+  return hasNItems(std::begin(C), std::end(C), N);
+}
+
----------------
mehdi_amini wrote:
> jurahul wrote:
> > mehdi_amini wrote:
> > > Seems like two patches here, this added function to STLExtras seems to be the only thing relevant for the MLIR part. Can you split this?
> > Sure, I can split the MLIR adoption of this into its own change.
> I meant that `hasNItems` and the MLIR change can go in together, but the addition of the others `hasNItemsOrLess` and `hasNItemsOrMore` don't seem related here.
I have split the MLIR change and added unit tests for these functions (and fixed a bug in `hasNItems`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82232/new/

https://reviews.llvm.org/D82232