[PATCH] D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 15:03:30 PDT 2020


ctetreau added a comment.

In D82329#2107553 <https://reviews.llvm.org/D82329#2107553>, @efriedma wrote:

> This code still won't actually work, either way.  (I think there's a patch out for review to disable GlobalISel for functions that contain scalable vectors?)
>
> If you don't want to deal with it now, just do `auto NumElements = cast<FixedVectorType>(VTy)->getNumElements();`


Unforunately, that causes llvm\test\CodeGen\AArch64\sve-intrinsics-ld1.ll to fail. So it's either this or calling getElementCount().Min. (or adding the feature)

I guess getElementCount().Min would eliminate the behavior change, but it's clearly broken and I'm not sure it's worth preserving the original behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82329/new/

https://reviews.llvm.org/D82329





More information about the llvm-commits mailing list