[PATCH] D82316: [LangRef] Add `frozen` attribute to documentation

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1255
 
+``"frozen"``
+    This attribute indicates that every bit of the parameter is required by
----------------
Should be just `frozen`, without the quotes. Quotes indicate a string attribute.


================
Comment at: llvm/docs/LangRef.rst:1259
+    requirement include structures with padding bits, unions with active
+    members smaller than their size, and scalars which were never initialized.
+
----------------
This description is a bit too frontend-centric. I'd suggest to at least add

> If the parameter is poison or contains undefined bits, the behavior is undefined.

to describe the actual IR semantic this has.

Also, can this be applied to return values? If so, it should say so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82316/new/

https://reviews.llvm.org/D82316