[PATCH] D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli accepted this revision.
fpetrogalli added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/InjectTLIMappings.cpp:148
   AU.addPreserved<OptimizationRemarkEmitterWrapperPass>();
+  AU.addPreserved<GlobalsAAWrapperPass>();
 }
----------------
rsanthir.quic wrote:
> fhahn wrote:
> > fpetrogalli wrote:
> > > Hi @rsanthir.quic 
> > > 
> > > Thank you for your patch.
> > > 
> > > Didn't you have to add this pass to the tests checking the pass sequence? Have you run `make check-all` on your changes?
> > > 
> > > Francesco
> > AFAIK if GlobalsAA is only used if it is available. So if it is not preserved, it won't be re-built, so this change won't impact any of the pipeline tests.
> Thanks for the explanation @fhahn, I did run make check-all as well, and I didnt notice any issues anyway @fpetrogalli 
Thank you for confirming, LGTM.

Francesco


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82063/new/

https://reviews.llvm.org/D82063