[PATCH] D81993: [AArch64][GlobalISel] Add post-legalize combine for sext(trunc(sextload)) -> trunc/copy
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 22 13:59:44 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:586
+ MI.getOperand(2).getImm();
+ return SrcSignBits == NumSextBits;
+}
----------------
This should be >=?
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:592
+ MachineIRBuilder MIB(MI);
+ MIB.buildAnyExtOrTrunc(MI.getOperand(0).getReg(), MI.getOperand(1).getReg());
+ MI.eraseFromParent();
----------------
I don't think introducing a new AnyExt would be right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81993/new/
https://reviews.llvm.org/D81993
More information about the llvm-commits
mailing list