[PATCH] D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction

[Whitney Tsang via Phabricator via llvm-commits]

Whitney marked an inline comment as done.
Whitney added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:313
 
-  if (I.isTerminator())
-    return reportInvalidCandidate(I, NotMovedTerminator);
----------------
bmahjour wrote:
> why do we start allowing terminators as safe candidates for code motion? Has this constraint been moved to another place that doesn't show up in this patch? The same question applies to checking for `isa<PHINode>(InsertPoint)` above.
Type of instructions are limited using `isSafeToMove`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82290/new/

https://reviews.llvm.org/D82290