[PATCH] D81457: [LLD][PowerPC] Add support for R_PPC64_PCREL34

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: lld/test/ELF/ppc64-reloc-pcrel34.s:37
+	.long	0
+	.size	glob_int8, 8
+
----------------
sfertile wrote:
> Do you want to define an int of size 4 or 8? you use an lwa so I would expect a 4 byte int, and you use .long which allocates 4 bytes (I belive its the same as .int), but then give it a size of 8 and name it as int8? Ditto for `glob_int8_big`
Sorry, what I meant to do was read the last 4 bytes of an 8 byte int.
I'm using `glob_int8 at PCREL+4` so I want to skip over the first 4 bytes and read the last 4. I'm actually testing the `+4`.
I guess `.long` is not the right type to use. I think `.quad` is correct here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81457/new/

https://reviews.llvm.org/D81457