[PATCH] D82309: [flang] Fix bug checking SAVE attribute

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 10:44:54 PDT 2020


tskeith added a comment.

In D82309#2107006 <https://reviews.llvm.org/D82309#2107006>, @jeanPerier wrote:

> Why not updating `semantics::IsSaved` to test `IsFunctionResult` instead like it is doing with `IsDummy` ?
>  Lowering relies on `IsSaved` to indicate whether something is implicitly or explicitly saved, so with this patch it looks like we would still create a global for `f2b` even if we should not.


OK, I've done that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82309/new/

https://reviews.llvm.org/D82309





More information about the llvm-commits mailing list