[PATCH] D82259: Deprecate error prone temporary directory APIs

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 09:07:43 PDT 2020


compnerd added a comment.

Thanks @davezarzycki!  Minor nit: git-clang-format the patch please, there was at least one linter warning in the changed code.

I do wonder if we can get away with the removal of the API though doing that in a follow up is pretty reasonable to me.

I think that one minor change is needed for this - an entry in the release notes would be nice to indicate to users that the cache paths have changed.  Its difficult to say if anyone is depending on it being in `TMP`, but it is a user visible change to the driver (though they still have control via `-fmodules-cache-path`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82259/new/

https://reviews.llvm.org/D82259





More information about the llvm-commits mailing list